Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using only-parameters for surveys + other performance issue #1504

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

Angamanga
Copy link
Contributor

@Angamanga Angamanga commented Dec 16, 2024

This PR 1. use ONLY-parameters for surveys and 2. only loads the connected survey when editing a post.

To test:
For filters:

  • Select filters->Surveys
  • The list should display Surveys
  • The request to get the survey should use ONLY parameters
  • When selecting a filter, only posts matching the filter should appear
    For adding/editing posts:
  • When adding a post, the survey-list should appear as usual, but faster
  • When clicking on a survey, there will be a little delay, because the whole survey is then loaded from the API
  • When editing a post, only the survey that the post is connected to is loaded from the API

This PR fixes USH-1513 and USH-800

Copy link

linear bot commented Dec 16, 2024

@Angamanga Angamanga marked this pull request as ready for review December 16, 2024 14:28
Copy link

linear bot commented Dec 16, 2024

@Angamanga Angamanga requested a review from ushahidlee December 16, 2024 14:29
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean and works great !

@Angamanga Angamanga merged commit ac957b4 into mobile-development Dec 18, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants