tsort: print nodes and cycles as they are visited #7093
+124
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom `Node::new` function with derived `Default` implementation, which does the same thing but more concisely.
jfinkels
force-pushed
the
tsort-print-cycle
branch
from
daf846d to
a666c58
Compare
Update `tsort` so that * nodes are printed as they are visited, * cycles are printed as they are discovered, * finding a cycle doesn't terminate the traversal, * multiple cycles can be found and displayed. Fixes uutils#7074
jfinkels
force-pushed
the
tsort-print-cycle
branch
from
a666c58 to
af99952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
tsortso thatThis isn't a perfect solution, as it breaks the cycles arbitrarily and just repeats the process until it can make more progress, but is an improvement on the previous situation.
Fixes #7074