This repository has been archived by the owner on Jan 6, 2025. It is now read-only.
I44 create evaluation #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frinzekt
reviewed
Jan 23, 2021
Comment on lines
63
to
66
| const response = await services["course-evaluation"].create({ | ||
| courseId: code, | ||
| reviewDescription: description, | ||
| }); |
There was a problem hiding this comment.
in relatively low effort, you can do "Auto redirect to new evaluation" using the information you get from this "_id"...
from there...
you could use router = useRouter() and router.push('coordinator/${_id}') ( i can't do backticks within code highlight)
frinzekt
approved these changes
Jan 23, 2021
Comment on lines
+144
to
+150
| <Datetime | ||
| onChange={(date) => { | ||
| setDueDate(date); | ||
| }} | ||
| value={dueDate} | ||
| placeholder="13/05/2031" | ||
| /> |
There was a problem hiding this comment.
I have added your dueDate modal, however, I did notice some discrepancy on the dueDate and the createdAt date... particularly I believe because of different time format.
See #46 , I dont plan to solve that in this pull request, nor in stage 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still todo:
Add dueDate field to evaluation document in database to add the ability to set a "due date" for reviewers.
Need:
Nice-to-haves: