Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public names output value to null backend #1408

Merged

Conversation

maximenoel8
Copy link
Contributor

What does this PR change?

In github action, we are using null backend for testing our main.tf. This backend doesn't support public names needed for AWS.
In this PR, I'm adding a default publis_names variable ouput for null backend

Github action error

╷
│ Error: Unsupported attribute
│ 
│   on main.tf line 717, in output "aws_mirrors_public_name":
│  717:   value = module.mirror.configuration.public_names
│     ├────────────────
│     │ module.mirror.configuration is object with 3 attributes
│ 
│ This object does not have an attribute named "public_names".
╵
Error: Terraform exited with code 1.
Error: Process completed with exit code 1.

@maximenoel8 maximenoel8 requested a review from a team October 11, 2023 22:01
Copy link
Member

@nodeg nodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, Maxime.

@maximenoel8 maximenoel8 merged commit 7b8da45 into uyuni-project:master Oct 13, 2023
2 checks passed
@maximenoel8 maximenoel8 deleted the add_public_ip_null_module branch October 13, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants