Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QE: Add client support for 15.6 client #1554

Conversation

vandabarata
Copy link
Contributor

@vandabarata vandabarata commented Mar 28, 2024

What does this PR change?

  • Adds client support for openSUSE Leap 15.6
  • Adds client to the controller
  • Updates mirror configuration

@vandabarata vandabarata self-assigned this Mar 28, 2024
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only found one potential problem

@@ -438,6 +438,10 @@ http:
archs: [x86_64]
- url: http://download.opensuse.org/update/leap/15.4/sle
archs: [x86_64]
- url: http://download.opensuse.org/update/leap/15.5/sle
archs: [x86_64]
- url: http://download.opensuse.org/update/leap/15.6/sle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one should go to minima-aarch64.yaml, maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's there too, I just have no idea what belongs where in the mirror and have just been "copying" the ones before 😅 I can remove it if it doesn't belong here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, all what we have in minima mirror configuration here, it should be aligned with the content we have in our internal minima mirror for CI/BV.

Comment on lines +148 to +149
opensuse156arm_minion = length(var.opensuse156arm_minion_configuration["hostnames"]) > 0 ? var.opensuse156arm_minion_configuration["hostnames"][0] : null
opensuse156arm_sshminion = length(var.opensuse156arm_sshminion_configuration["hostnames"]) > 0 ? var.opensuse156arm_sshminion_configuration["hostnames"][0] : null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about x86_64 flavours?

Comment on lines +690 to +703
variable "opensuse156arm_minion_configuration" {
description = "use module.<OPENSUSE156ARM_MINION>.configuration, see main.tf.libvirt-testsuite.example"
default = {
hostnames = []
}
}

variable "opensuse156arm_sshminion_configuration" {
description = "use module.<OPENSUSE156ARM_SSHMINION>.configuration, see main.tf.libvirt-testsuite.example"
default = {
hostnames = []
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the possibility to use x86_64 too.

Comment on lines +105 to +106
{% if grains.get('opensuse156arm_minion') | default(false, true) %}export OPENSUSE156ARM_MINION="{{ grains.get('opensuse156arm_minion') }}" {% else %}# no OPENSUSE156ARM minion defined {% endif %}
{% if grains.get('opensuse156arm_sshminion') | default(false, true) %}export OPENSUSE156ARM_SSHMINION="{{ grains.get('opensuse156arm_sshminion') }}" {% else %}# no OPENSUSE156ARM ssh minion defined {% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the possibility to use x86_64 too.

@srbarrios
Copy link
Member

I would clarify in the title that we only cover libvirt case here, keeping other backends out of the scope for now.

@vandabarata
Copy link
Contributor Author

I'm merging this as it is for now, to maintain consistency with the previous opensuse flavours - only supported for ARM

@vandabarata vandabarata merged commit f3f5045 into uyuni-project:master Apr 4, 2024
3 checks passed
@vandabarata vandabarata deleted the qe-vb-add-client-support-to-156-arm branch April 4, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants