Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SL Micro 6.0 hosts, including Salt Shaker #1583

Merged
merged 7 commits into from
May 16, 2024
Merged

Add support for SL Micro 6.0 hosts, including Salt Shaker #1583

merged 7 commits into from
May 16, 2024

Conversation

meaksh
Copy link
Member

@meaksh meaksh commented May 14, 2024 •
edited
Loading

What does this PR change?

This PR includes some extra commits on top of #1550 in order to:

  • Rename from SLEMicro6.0 to SLMicro6.0.
  • Use sumaform image for SLMicro6 building in OBS.
  • Use combustion instead of cloud init for SL Micro 6.0.
  • Add support for Salt Shaker deployment.

/cc @ktsamis for awareness

@meaksh meaksh mentioned this pull request May 14, 2024
Merged
@meaksh meaksh changed the title Add support for SL Micro 6 hosts, including Salt Shaker Add support for SL Micro 6.0 hosts, including Salt Shaker May 15, 2024
ktsamis
ktsamis approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried we will confuse the variables without the 'e' but it's technically correct. And this PR looks great, thanks Pablo.

This was referenced May 16, 2024
Closed
Merged
vzhestkov
vzhestkov approved these changes May 16, 2024
View reviewed changes
Copy link

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@meaksh meaksh merged commit c89db10 into master May 16, 2024
3 checks passed
@meaksh meaksh deleted the master-add-slmicro-support branch May 16, 2024 14:51
@meaksh meaksh mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhestkov vzhestkov vzhestkov approved these changes

@ktsamis ktsamis ktsamis approved these changes

@srbarrios srbarrios srbarrios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meaksh @srbarrios @ktsamis @vzhestkov