Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode a fixed release value but align it with the value used while tagging #11

Merged

Conversation

deneb-alpha
Copy link
Contributor

Do not hardcode a fixed release value but align it with the value used while tagging.

Tested in:

Now, if a source has been tagged using tito tag --use-release=0 the Release: will be set to 0, in case of sources still tagged with the default Release: 1 , the build script keep the 1 as a value.

a few examples from my branch:

Same sources from Devel:Galaxy:Manager:Head:

for an untagged change, you can look at the current version of uyuni-releng-tools from this PR that is built in

@deneb-alpha deneb-alpha requested a review from a team as a code owner April 9, 2024 12:32
@deneb-alpha deneb-alpha requested a review from cbosdo April 9, 2024 12:32
@deneb-alpha deneb-alpha self-assigned this Apr 9, 2024
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deneb-alpha deneb-alpha force-pushed the do_not_hardcode_release_value branch 2 times, most recently from 1f50071 to 51acaac Compare April 9, 2024 12:44
Copy link
Member

@juliogonzalez juliogonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bin/build-packages-for-obs Show resolved Hide resolved
bin/build-packages-for-obs Show resolved Hide resolved
@deneb-alpha deneb-alpha force-pushed the do_not_hardcode_release_value branch from 0384de7 to fbb5ce3 Compare April 9, 2024 13:25
@deneb-alpha
Copy link
Contributor Author

@deneb-alpha deneb-alpha merged commit e82bee8 into uyuni-project:main Apr 9, 2024
1 check passed
@deneb-alpha deneb-alpha deleted the do_not_hardcode_release_value branch April 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants