Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not override custom header footer part names #6632

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

tomivirkki
Copy link
Member

Description

Fixes a bug discovered while working on the Flow counterpart for #6629: custom header/footer part names can get overridden when a new column is added to the grid.

Type of change

Bugfix

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshots need to be updated due to different part attribute order.

@tomivirkki
Copy link
Member Author

Snapshots need to be updated due to different part attribute order.

Done.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki merged commit af30824 into main Oct 11, 2023
9 checks passed
@tomivirkki tomivirkki deleted the fix/grid/overridden-custom-part-names branch October 11, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants