fix: set max-height on popover overlay to not overflow viewport #8095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Nov 5, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
web-padawan
added a commit
that referenced
this pull request
Nov 5, 2024
… (#8096) Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8016
Unlike
vaadin-dialog, thevaadin-popoverwas missingmax-height: 100%on the overlay part.Also, I had to set it on the content part as well in order to make sure scrolling works properly.
Note: original styles for dialog were added in vaadin/vaadin-dialog#168 but in case of popover we need a slightly different approach since we don't have a "resizer container" element.
Here's how the resulting behavior looks like:
popover-scroll.mp4
Type of change