[Core] Feature Smile-SA#3432, code refactoring

vahonc · Jan 13, 2025 · d3ec33b · d3ec33b
1 parent 214b13d
commit d3ec33b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/src/module-elasticsuite-core/Api/Healthcheck/CheckInterface.php b/src/module-elasticsuite-core/Api/Healthcheck/CheckInterface.php
@@ -19,6 +19,11 @@
  */
 interface CheckInterface
 {
+    /**
+     * Warning status declaration.
+     */
+    const WARNING_STATUS = 'warning';
+
     /**
      * Retrieve the unique identifier for the health check.
      *

diff --git a/src/module-elasticsuite-core/Model/Healthcheck/ReplicasConfigCheck.php b/src/module-elasticsuite-core/Model/Healthcheck/ReplicasConfigCheck.php
@@ -41,8 +41,6 @@ class ReplicasConfigCheck implements CheckInterface
      */
     private const ES_INDICES_SETTINGS_WIKI_PAGE = 'https://github.com/Smile-SA/elasticsuite/wiki/ModuleInstall#indices-settings';
 
-    public const WARNING_STATUS = 'warning';
-
     /**
      * @var IndexSettingsHelper
      */
@@ -94,7 +92,7 @@ public function getDescription(): string
     {
         $status = $this->getStatus();
 
-        if ($status === self::WARNING_STATUS) {
+        if ($status === CheckInterface::WARNING_STATUS) {
             // Description when the replicas configuration is incorrect.
             // @codingStandardsIgnoreStart
             return __(

diff --git a/src/module-elasticsuite-core/Model/Healthcheck/ShardsConfigCheck.php b/src/module-elasticsuite-core/Model/Healthcheck/ShardsConfigCheck.php
@@ -42,8 +42,6 @@ class ShardsConfigCheck implements CheckInterface
      */
     private const ES_INDICES_SETTINGS_WIKI_PAGE = 'https://github.com/Smile-SA/elasticsuite/wiki/ModuleInstall#indices-settings';
 
-    public const WARNING_STATUS = 'warning';
-
     public const UNDEFINED_SIZE = 'N/A';
 
     /**
@@ -100,7 +98,7 @@ public function getDescription(): string
         $maxIndexSize = $this->getMaxIndexSize();
         $status = $this->getStatus();
 
-        if ($status === self::WARNING_STATUS) {
+        if ($status === CheckInterface::WARNING_STATUS) {
             // Description when the shard's configuration is incorrect.
             // @codingStandardsIgnoreStart
             return __(

diff --git a/src/module-elasticsuite-core/Model/System/Message/GenericHealthcheckWarning.php b/src/module-elasticsuite-core/Model/System/Message/GenericHealthcheckWarning.php
@@ -16,6 +16,7 @@
 
 use Magento\Framework\UrlInterface;
 use Magento\Framework\Notification\MessageInterface;
+use Smile\ElasticsuiteCore\Api\Healthcheck\CheckInterface;
 use Smile\ElasticsuiteCore\Model\Healthcheck\HealthcheckList;
 
 /**
@@ -38,8 +39,6 @@ class GenericHealthcheckWarning implements MessageInterface
      */
     private $urlBuilder;
 
-    public const WARNING_STATUS = 'warning';
-
     /**
      * Constructor.
      *
@@ -105,7 +104,7 @@ private function getIssueCount(): int
         $issuesCount = 0;
 
         foreach ($this->healthcheckList->getChecks() as $check) {
-            if ($check->getStatus() === self::WARNING_STATUS) {
+            if ($check->getStatus() === CheckInterface::WARNING_STATUS) {
                 $issuesCount++;
             }
         }