1.20.1 #365
Merged
1.20.1 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.20.1 is compatible with 1.20 So I think we actually need to stick with #358 |
|
that pr, being in progress, has a bug that costs us a couple of hours of debugging last night that we managed to find eventually, this one fixes those but are not yet commited, as i can not directly push to that branch (i think), i made this pr go into that one. |
dyc3
approved these changes
Jun 13, 2023
|
Thanks for figuring it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes you've made. Link to any issues this PR fixes or addresses.
Into the mc-1.20 branch for now, can change to main if desired. got this to connect/play on the conway example on a 1.20.1 client
(most credits go to dyc ofc)