-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
world time implementation #526
base: main
Are you sure you want to change the base?
Conversation
It looks like this pull request changed the workspace structure. Please replace depgraph.svg (Don't forget the trailing newline)
For reference, here is a diff against the old
|
#533 is going to change the way layers work, so I'd like to see how that shakes out before committing to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for initial implementation.
Does something block this pull request from being merged? |
} | ||
``` | ||
|
||
## Advacing the world time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Advacing the world time | |
## Advancing the world time |
Since the last time I implemented world time, the
main
branch has been updated significantly. Merging my previous pull request #370 requires more effort than reimplementing from scratch. As a result, this PR will supersede #370.Description
Implementation of world time for instance. Support sets the time explicitly, advances the time, and adjusts the frequency that the server sends
WorldTimeUpdateS2c
packet to clients.Playground:
example:
cargo run --package valence --example time_travel
tests:
cargo test --package valence --lib -- tests::world_time
Related
part of #210