h2: the :scheme pseudo header is not optional #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The :scheme pseudo header is not optional in H/2 except when doing CONNECT. There is also a strict requirement for it appear only once. Signed-off-by: Asad Sajjad Ahmed <[email protected]> Conflicts: bin/varnishtest/tests/t02025.vtc
nigoroll
approved these changes
Oct 18, 2023
dridi
commented
Nov 27, 2023
Comment on lines
+604
to
+610
| int scheme_seen; | ||
| h2_error h2e; | ||
| ssize_t cl; | ||
|
|
||
| ASSERT_RXTHR(h2); | ||
| assert(r2->state == H2_S_OPEN); | ||
| scheme_seen = h2->decode->flags & H2H_DECODE_FLAG_SCHEME_SEEN; |
There was a problem hiding this comment.
I'm not convinced we need this local variable when we use it just once. I will add a separate commit to maintain the authorship of this one.
There was a problem hiding this comment.
fwiw, I think wrt machine code the local variable makes no difference
|
bugwash: ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :scheme pseudo header is not optional in H/2 except when doing CONNECT. There is also a strict requirement for it appear only once.
Signed-off-by: Asad Sajjad Ahmed [email protected]
Conflicts:
bin/varnishtest/tests/t02025.vtc
This was submitted to the 6.0 branch instead of trunk first. I noticed it thanks to the test case collision while porting #3998 to the 6.0 branch.