param: Enable absolute bits parameters #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigoroll
approved these changes
Nov 13, 2023
The most significant bits of the least significant octet would be omitted when the number of bits is not a multiple of eight.
As opposed to special values. This enables setting "absolute" values
atomically:
param.set foo none,+bar,+baz
Better diff with the --ignore-all-space option.
This is primarily for self-documentation purposes, but also to simplify the bit tweak.
We have had the ability to reset any parameter to its default value for a while now.
|
I reworded the first commit message, hence the force-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
param.set -jperforming the regularparam.setoperation but outputtingparam.show -jwe made it possible for "operators" to atomically set a parameter to a specific value, and know how it would be rendered. This enables safe periodic consistency checks to undo potential manual tweaks.This change however, left a blind spot for bits parameters, since we either set them to their default value via the "none" or "default" special values, and otherwise with relative values in the form of a series of
-xxxor+yyytokens.This patch series adds a new "all" value and allows "all" and "none" to appear in the bits list:
It also changes the relative default values of some bits parameters to make them all absolute.
The "default" special value is marked as deprecated in favor of
param.reset.The
param.resetcommand grew a-joption to behave likeparam.set, for consistency.Last but not least, it fixes the handling of "none" and "default" that could spuriously leave up to 7 most significant bits raised.