Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtc: Stabilize r02310.vtc #4099

Merged
merged 1 commit into from
May 6, 2024
Merged

vtc: Stabilize r02310.vtc #4099

merged 1 commit into from
May 6, 2024

Conversation

walid-git
Copy link
Member

The test is racy, since #3998 we no longer perform the backend fetch if the client disconnects before it is started. Thus, the test will be stuck at this line until it times out since the other barrier b1 sync will never be reached.

Fixes: #4098

@walid-git
vtc: Stabilize r02310.vtc
4f35b02 
The test is racy, we should always perform the backend fetch to reach
the "barrier b1 sync" in the server body, otherwise the test will be
stuck on the second barrier sync until timeout.

Fixes: varnishcache#4098
@dridi dridi mentioned this pull request Apr 30, 2024
Closed
dridi
dridi approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@dridi dridi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@dridi dridi merged commit 7f04ec5 into varnishcache:master May 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dridi dridi dridi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent timeout in r02310.vtc
2 participants
@walid-git @dridi