Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vev: Log where MGT received its signal from #4139

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

cartoush
Copy link
Contributor

This PR makes MGT log from which PID originates the signal it received.
It does that by adding the SIGINFO flag to sigaction in order to use sa_sigaction insead of sa_handler and grab the struct siginfo_t which contains the origin PID

Copy link
Member

@nigoroll nigoroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, i have nitpicks

bin/varnishd/mgt/mgt_vcl.c Show resolved Hide resolved
lib/libvarnish/vev.c Show resolved Hide resolved
@cartoush cartoush force-pushed the sigint_origin_log branch from 5265875 to 36bc3d9 Compare July 31, 2024 12:49
@cartoush cartoush force-pushed the sigint_origin_log branch 2 times, most recently from b51c52d to 80ae6a3 Compare August 23, 2024 10:05
@nigoroll
Copy link
Member

bugwash: OK
I am going to slightly edit and merge

@nigoroll nigoroll merged commit 0fa9533 into varnishcache:master Sep 30, 2024
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants