WIP: fix connwait signalling vs. VDI/VBE layering #4184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the idea here is to use the backend's healthy callback to signal to it a health change from outside. this fixes the regression from varnishcache#4183, but makes v74.vtc fail. And also I am not happy about the locking involved and need to spend more time...
|
No, this is a bad idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea here is to use the backend's healthy callback to signal to it a health change from outside.
this fixes the regression from #4183, but makes v74.vtc fail. And also I am not happy about the locking involved and need to spend more time...