Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests get larger thread pool, necessary for ppc32 #4188

Merged

Conversation

ingvarha
Copy link
Contributor

The former threadpool size of 80k fails on 32bit ppc (at least on my Debian/ppc32)

**** v1 CLI TX|param.set thread_pool_stack 80k
**** dT 0.197
*** v1 CLI RX 106
**** v1 CLI RX|Must be at least 128k

Upping to 128k makes the test suite run.

@dridi
Copy link
Member

dridi commented Sep 19, 2024

The alternative to an increase in stack size could be -cli instead of -cliok to ignore failures when we set a stack size lower than the platform's minimum.

Could you please try that?

@bsdphk
Copy link
Contributor

bsdphk commented Sep 23, 2024

I'm OK with s/80k/128k/

The 80k was set in the previous commit (55fecc9) and seems like an arbitrary choice of no importance for the actual tests ?

@nigoroll nigoroll merged commit e134438 into varnishcache:master Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants