Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCL: Restrict scope of req.is_hit{miss,pass} #4206

Merged
merged 3 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ Varnish Cache NEXT (2025-03-15)
.. PLEASE keep this roughly in commit order as shown by git-log / tig
(new to old)

* The scope of VCL variables `req.is_hitmiss` and `req.is_hitpass` is now restricted
to `vcl_miss, vcl_deliver, vcl_pass, vcl_synth` and `vcl_pass, vcl_deliver, vcl_synth`
respectively.

================================
Varnish Cache 7.6.0 (2024-09-13)
================================
Expand Down
4 changes: 2 additions & 2 deletions doc/sphinx/reference/vcl_var.rst
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ req.is_hitmiss

Type: BOOL

Readable from: client
Readable from: vcl_miss, vcl_deliver, vcl_pass, vcl_synth

If this request resulted in a hitmiss

Expand All @@ -392,7 +392,7 @@ req.is_hitpass

Type: BOOL

Readable from: client
Readable from: vcl_pass, vcl_deliver, vcl_synth

If this request resulted in a hitpass

Expand Down