Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: clicking on the top row causes the Generator Start/Stop menu option to be triggered #1714

Closed
blammit opened this issue Nov 11, 2024 · 6 comments · Fixed by #1799
Closed

Settings: clicking on the top row causes the Generator Start/Stop menu option to be triggered #1714

blammit opened this issue Nov 11, 2024 · 6 comments · Fixed by #1799
Assignees
@MikeTrahearn-Qinetic
Labels
low_prio
Milestone
Version 1.1.0

Comments

@blammit
Copy link
Contributor

blammit commented Nov 11, 2024

See thread and video here: https://victrondevelopment.slack.com/archives/C04RYU0UMDE/p1731142689206319
@blammit blammit added this to the Version 1.1.0 milestone Nov 11, 2024
@MikeTrahearn-Qinetic
Copy link
Contributor

I need access to the victron slack to be able to view the issue details.

@blammit
Copy link
Contributor Author

blammit commented Dec 2, 2024 •
edited
Loading

(Access has now been provided.)

Also reported here: "Sometimes, when clicking on the clock/WiFi symbol, the underlying menu entry opens. I discovered it, because I was wondering why the Bluetooth settings open, when I click on the WiFi symbol."

@MikeTrahearn-Qinetic
Copy link
Contributor

I have been able to reproduce this.

@MikeTrahearn-Qinetic
Copy link
Contributor

On investigation it has been found as suspected that the clickable delegates in the Settings list view are not being clipped by the view and are thus clickable through the status bar - AND the navigation bar.
The image below shows this happening clearly as I have made the status and navigation bar slightly transparent, showing the obvious problem in the annotated red areas.
Settings Not Cropped

MikeTrahearn-Qinetic added a commit that referenced this issue Dec 12, 2024
@MikeTrahearn-Qinetic
Fix SettingsPage's GradientListView to add clipping
8564abb 
Clip the GradientListView to prevent delegates that extend beyond
the ListView's top and bottom edges from being clickable outside
of those boundaries.

Fixes #1714
@MikeTrahearn-Qinetic
Copy link
Contributor

Adding clipping to the GradientListView in pages/SettingsPage.qml fixes this issue.

@MikeTrahearn-Qinetic
Copy link
Contributor

MikeTrahearn-Qinetic commented Dec 12, 2024 •
edited
Loading

  • Test on Desktop
  • Test on WASM
  • Test on Cerbo

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic linked a pull request Dec 12, 2024 that will close this issue
Fix SettingsPage's GradientListView to add clipping #1799
Merged
Merged
MikeTrahearn-Qinetic added a commit that referenced this issue Dec 16, 2024
@MikeTrahearn-Qinetic
Fix SettingsPage's GradientListView to add clipping
5a676a9 
Clip the GradientListView to prevent delegates that extend beyond
the ListView's top and bottom edges from being clickable outside
of those boundaries.

Fixes #1714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeTrahearn-Qinetic MikeTrahearn-Qinetic

Labels
low_prio
Projects
None yet
Milestone
Version 1.1.0
Development

Successfully merging a pull request may close this issue.

Fix SettingsPage's GradientListView to add clipping victronenergy/gui-v2
2 participants
@blammit @MikeTrahearn-Qinetic