Fix SettingsPage's GradientListView to add clipping #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clip the GradientListView to prevent delegates that extend beyond the ListView's top and bottom edges from being clickable outside of those boundaries. Fixes #1714
chriadam
approved these changes
Dec 13, 2024
|
Nice catch! |
MikeTrahearn-Qinetic
deleted the
miketrahearn/1714-fix-settings-listview-clipping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clip the GradientListView to prevent delegates that extend beyond the ListView's top and bottom edges from being clickable outside of those boundaries.
This was reproduced and the root cause discovered.
Tested the fix on Desktop, WASM and Cerbo as "can no longer reproduce".
Fixes #1714