Use VeQuickItem::numberValue to reduce binding overheads #1184
Conversation
|
This one is risky, and unnecessary - we easily hit the performance requirement (in electrons-paused mode) without this PR. |
chriadam
force-pushed
the
chriadam/performance-investigation-2-no-clip
branch
from
0819074 to
c0af932
Compare
components/ThreePhaseBarGauge.qml
Outdated
| @@ -17,6 +17,7 @@ Flow { | |||
| property bool inputMode | |||
| property int orientation: Qt.Vertical | |||
| property bool animationEnabled | |||
| property bool inOverviewWidget | |||
There was a problem hiding this comment.
leftovers from when I force pushed the other PR. This PR is targeted at the other branch :-/
chriadam
force-pushed
the
chriadam/performance-investigation-2-no-clip
branch
from
c0af932 to
866c191
Compare
chriadam
force-pushed
the
chriadam/performance-investigation-risky
branch
from
394da2f to
39940a5
Compare
chriadam
force-pushed
the
chriadam/performance-investigation-2-no-clip
branch
2 times, most recently
from
d25aab0 to
ba3e0b0
Compare
chriadam
force-pushed
the
chriadam/performance-investigation-risky
branch
from
39940a5 to
353a587
Compare
chriadam
force-pushed
the
chriadam/performance-investigation-2-no-clip
branch
from
ba3e0b0 to
223c102
Compare
chriadam
force-pushed
the
chriadam/performance-investigation-risky
branch
from
353a587 to
f025ac6
Compare
chriadam
force-pushed
the
chriadam/performance-investigation-2-no-clip
branch
from
223c102 to
3795263
Compare
chriadam
force-pushed
the
chriadam/performance-investigation-risky
branch
from
f025ac6 to
3c33176
Compare
chriadam
force-pushed
the
chriadam/performance-investigation-risky
branch
from
3c33176 to
11480f0
Compare
|
We might be able to use nullish coalescing to get the same benefit instead, i.e. change
to
as long as that still results in one reading of I think we should start using this in the codebase generally to make things more concise. |
|
Does QML's fast-path JS expression evaluator support nullish coalescing, or does it fall back to full JS context evaluation for expressions containing those? |
No idea, probably requires hunting through the source to find out. |
No description provided.