Fix position of "connected" icon in Wi-Fi networks list #1849
Conversation
This also avoids the warning "Cannot anchor to an item that isn't a parent or sibling" when opening PageSettingsWifi.qml.
| @@ -84,9 +84,10 @@ Page { | |||
| primaryLabel.leftPadding: Theme.geometry_icon_size_medium + Theme.geometry_listItem_content_spacing | |||
|
|
|||
| CP.ColorImage { | |||
| parent: delagate.primaryLabel | |||
There was a problem hiding this comment.
Is delagate intentionally misspelled to avoid clashing with the delegate keyword? I just tried fixing the spelling, and the result works fine on a site with favorite wifi connections such as 151899
There was a problem hiding this comment.
You can indeed use the id spelled the same as a property but my preference would be to give it a meaningful name instead of creating visual ambiguity (even though the compiler will favour using the id. In fact in stricter/newer versions of Qt to reference only the property delegate will create an unqualified reference error because the "delagate" is in fact a Component, not an object and to force it to do so would require adding pragma ComponentBehavior: Bound - something not available in Qt 6.6.
There was a problem hiding this comment.
I think the "delagate" was a misspelling when the change was first added, and just "delegate" would be fine. But yes, a more meaningful name would be better too.
I'll leave the PR as-is since the naming is a separate issue.
This also avoids the warning "Cannot anchor to an item that isn't a parent or sibling" when opening PageSettingsWifi.qml.