Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm msgpack dependency #208

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Remove npm msgpack dependency #208

merged 5 commits into from
Sep 16, 2024

Conversation

Shougo
Copy link
Contributor

@Shougo Shougo commented Sep 15, 2024

No description provided.

@Shougo Shougo requested a review from kuuote September 15, 2024 03:23
@Shougo
Copy link
Contributor Author

Shougo commented Sep 15, 2024

error: TS2352 [ERROR]: Conversion of type 'string | number | bigint | boolean | Uint8Array | readonly ValueType[] | ValueMap | null' to type 'Jisyo' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
  Type 'ValueMap' is missing the following properties from type 'Jisyo': okuri_ari, okuri_nasi
    const jisyo = msgpackDecode(data) as Jisyo;
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    at file:///home/runner/work/skkeleton/skkeleton/repo/denops/skkeleton/sources/deno_kv.ts:241:19

TS2352 [ERROR]: Conversion of type 'string | number | bigint | boolean | Uint8Array | readonly ValueType[] | ValueMap | null' to type 'Jisyo' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
  Type 'ValueMap' is missing the following properties from type 'Jisyo': okuri_ari, okuri_nasi
    const jisyo = msgpackDecode(data) as Jisyo;
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    at file:///home/runner/work/skkeleton/skkeleton/repo/denops/skkeleton/sources/skk_dictionary.ts:161:19

Found 2 errors.

Hm...

denops/skkeleton/sources/deno_kv.ts Outdated Show resolved Hide resolved
denops/skkeleton/sources/skk_dictionary.ts Outdated Show resolved Hide resolved
@kuuote
Copy link
Member

kuuote commented Sep 16, 2024

Thanks.

@kuuote kuuote merged commit 039aebf into main Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants