Carto: Support styling layer by color column #8177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
requested changes
Oct 6, 2023
felixpalmer
reviewed
Oct 10, 2023
felixpalmer
requested changes
Oct 18, 2023
modules/carto/src/api/layer-map.ts
Outdated
| @@ -380,6 +372,33 @@ export function getColorAccessor( | |||
| return normalizeAccessor(accessor, data); | |||
| } | |||
|
|
|||
| export function getDomainAndScaleColor(name, scaleType, range, data) { | |||
There was a problem hiding this comment.
Why do you need to introduce this new function? I feel it just makes the code harder to follow
There was a problem hiding this comment.
I don't need but I think that it's more clear than having a long function. This function is just calculating the domain and scaleColor for each case.
There was a problem hiding this comment.
OK, but can your rename to calculateLayerScale, remove the export and put these three lines in the helper function:
scale.domain(domain);
scale.range(scaleColor);
scale.unknown(UNKNOWN_COLOR);
and then just return the scale
felixpalmer
requested changes
Oct 23, 2023
modules/carto/src/api/layer-map.ts
Outdated
| @@ -380,6 +372,33 @@ export function getColorAccessor( | |||
| return normalizeAccessor(accessor, data); | |||
| } | |||
|
|
|||
| export function getDomainAndScaleColor(name, scaleType, range, data) { | |||
There was a problem hiding this comment.
OK, but can your rename to calculateLayerScale, remove the export and put these three lines in the helper function:
scale.domain(domain);
scale.range(scaleColor);
scale.unknown(UNKNOWN_COLOR);
and then just return the scale
felixpalmer
approved these changes
Oct 23, 2023
…f github.com:visgl/deck.gl into feature/sc-353849/apply-hexcolor-to-deck-gl-fetchmap
Josmorsot
deleted the
feature/sc-353849/apply-hexcolor-to-deck-gl-fetchmap
branch
felixpalmer
pushed a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Allow to style a layer using the a color property.
Change List
HexColor columninfetchMap