[EXPERIMENTAL] replace map-div with gmp-map custom element
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulthink
changed the title
gmp-map custom elementgmp-map custom element
usefulthink
changed the title
gmp-map custom elementgmp-map custom element
usefulthink
force-pushed
the
experimental/web-component-support
branch
from
2f7527f to
e41a74c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment to use the
gmp-mapcustom element instead of a plain div element in the renderer.The main reason to make this switch once the google maps web-components are stable is to allow interoperability with other web-components like the ones from the
@googlemaps/extended-component-librarypackage.It looks like this will happen some time later this year, but probably after the 1.0 release.
Initial tests look promising though, I didn't get around to fix the unit-tests, but nothing seems seriously broken from a quick look. Next would be to test if this works together with other web-components.