Skip to content

Commit

Permalink
fix: error in react/storybook
Browse files Browse the repository at this point in the history
This fixes the following problems:

- "TypeError: Cannot read properties of undefined" occurred in Renderer.stories.js
- docs.autodocs setting that was added by `npx storybook@latest upgrade` in PR #1419 is not needed and commented out.
- "build-dev" in packages/core did not generate type definitions and build-dev failed in packages/react.
- microbundle-crl is old and not maintained, so it should be replaced with microbundle.
  • Loading branch information
MurakamiShinyu committed Nov 17, 2024
1 parent 2a86d2c commit e7ef7f9
Show file tree
Hide file tree
Showing 4 changed files with 200 additions and 954 deletions.
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"author": "Vivliostyle Foundation",
"scripts": {
"build": "tsc --emitDeclarationOnly && esbuild src/vivliostyle.ts --bundle --outfile=lib/vivliostyle.js --format=cjs --define:VIVLIOSTYLE_DEBUG=false --minify --sourcemap --target=es2018",
"build-dev": "esbuild src/vivliostyle.ts --bundle --outfile=lib/vivliostyle.js --format=cjs --define:VIVLIOSTYLE_DEBUG=true --sourcemap --target=es2018",
"build-dev": "tsc --emitDeclarationOnly && esbuild src/vivliostyle.ts --bundle --outfile=lib/vivliostyle.js --format=cjs --define:VIVLIOSTYLE_DEBUG=true --sourcemap --target=es2018",
"clean": "shx rm -rf lib/* .cache",
"dev": "yarn build-dev --watch=forever",
"format": "prettier --write \"{*.{js,md,json},{src,types,test,resources}/**/*.{ts,js}}\"",
Expand Down
6 changes: 3 additions & 3 deletions packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"version": "2.30.5",
"author": "Yasuaki Uechi <[email protected]>",
"scripts": {
"build": "microbundle-crl --format modern,cjs && shx rm -rf dist/stories",
"build-dev": "microbundle-crl --no-compress --format cjs",
"build": "microbundle --format modern,cjs && shx rm -rf dist/stories",
"build-dev": "microbundle --no-compress --format cjs",
"build-storybook": "storybook build",
"clean": "shx rm -rf dist",
"dev": "yarn storybook",
Expand Down Expand Up @@ -36,7 +36,7 @@
"@types/jest": "^29.5.14",
"@types/react": "^18.0.27",
"cross-env": "^7.0.2",
"microbundle-crl": "^0.13.10",
"microbundle": "^0.15.1",
"npm-run-all": "^4.1.5",
"react": "^18.2.0",
"react-dom": "^18.2.0",
Expand Down
1 change: 1 addition & 0 deletions packages/react/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"lib": ["dom", "esnext"],
"moduleResolution": "node",
"jsx": "react",
"jsxFactory": "React.createElement",
"sourceMap": true,
"declaration": true,
"esModuleInterop": true,
Expand Down
Loading

0 comments on commit e7ef7f9

Please sign in to comment.