Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add fused_moe config for DeepSeek-V3 #11820

Closed

Conversation

Pernekhan
Copy link
Contributor

@Pernekhan Pernekhan commented Jan 7, 2025

No description provided.

Copy link

github-actions bot commented Jan 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Pernekhan Pernekhan changed the title Add fused_moe config for DeepSeek-V3 [Draft] Add fused_moe config for DeepSeek-V3 Jan 7, 2025
Signed-off-by: Pernekhan Utemuratov <[email protected]>
@Pernekhan Pernekhan force-pushed the fused-moe-config-for-deepseek-v3 branch from 707035b to d8ffa85 Compare January 7, 2025 23:46
@Pernekhan Pernekhan changed the title [Draft] Add fused_moe config for DeepSeek-V3 Add fused_moe config for DeepSeek-V3 Jan 7, 2025
@mergify mergify bot added the ci/build label Jan 9, 2025
Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 10, 2025
@ywang96 ywang96 enabled auto-merge (squash) January 10, 2025 18:32
@simon-mo simon-mo disabled auto-merge January 10, 2025 19:27
@simon-mo
Copy link
Collaborator

HI @Pernekhan, thank you for the PR. We currently support the block wise w8a8 which is different from what this PR added under vllm/model_executor/layers/fused_moe/configs/E=256,N=256,device_name=NVIDIA_H200,dtype=fp8_w8a8.json

Is this for a different checkpoint that performed the fp8_w8a8 quantization?

cc @mgoin

@Pernekhan
Copy link
Contributor Author

@simon-mo let me mark this PR as a draft for now, it's not finalized yet. I'll reopen this PR later once we're finalized.

@Pernekhan Pernekhan changed the title Add fused_moe config for DeepSeek-V3 [DRAFT] Add fused_moe config for DeepSeek-V3 Jan 10, 2025
@Pernekhan Pernekhan closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants