Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Remove experimental dep from tracing.py #12007

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Jan 13, 2025

Currently, the OpenTelemetry POC imports constants from a type that no longer exists. This copies the constants instead as is usually advised to prevent version locks.

This also finishes name conversion from llm -> gen_ai per upstream https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-spans.md

Fix #11993

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

GEN_AI_REQUEST_TOP_P = "gen_ai.request.top_p"
GEN_AI_REQUEST_TEMPERATURE = "gen_ai.request.temperature"
GEN_AI_RESPONSE_MODEL = "gen_ai.response.model"
# Attribute names added until they are added to the semantic conventions:
Copy link
Contributor Author

@codefromthecrypt codefromthecrypt Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I left these alone, but some look like they are attributes or names of metrics, not spans. Perhaps double-check at some point if it is desired to capture these datapoints as span attributes vs metrics.

https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-metrics.md

@codefromthecrypt
Copy link
Contributor Author

I think the failure is unrelated:

[2025-01-13T13:33:36Z] E           huggingface_hub.errors.HfHubHTTPError: 500 Server Error: Internal Server Error for url: https://huggingface.co/facebook/opt-125m/resolve/main/sentence_camembert_config.json (Request ID: Root=1-678514f3-7a782ba707c969e359375b92;ed6140ec-8e9a-40c9-ba03-bb46e895e54f)
--
  | [2025-01-13T13:33:36Z] E
  | [2025-01-13T13:33:36Z] E           The request is taking longer than expected, please try again later.

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jan 21, 2025

Sorry for the delay, I think @rkooo567 (who originally worked on this) is busy nowadays so he doesn't have time to review this. Your changes look good to me!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 21, 2025 04:01
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 21, 2025
@simon-mo simon-mo disabled auto-merge January 21, 2025 19:51
@simon-mo simon-mo merged commit 347eeeb into vllm-project:main Jan 21, 2025
63 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: opentelemetry POC not compatible with latest
3 participants