-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Remove experimental dep from tracing.py #12007
Conversation
Signed-off-by: Adrian Cole <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
GEN_AI_REQUEST_TOP_P = "gen_ai.request.top_p" | ||
GEN_AI_REQUEST_TEMPERATURE = "gen_ai.request.temperature" | ||
GEN_AI_RESPONSE_MODEL = "gen_ai.response.model" | ||
# Attribute names added until they are added to the semantic conventions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: I left these alone, but some look like they are attributes or names of metrics, not spans. Perhaps double-check at some point if it is desired to capture these datapoints as span attributes vs metrics.
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-metrics.md
I think the failure is unrelated:
|
Sorry for the delay, I think @rkooo567 (who originally worked on this) is busy nowadays so he doesn't have time to review this. Your changes look good to me! |
Currently, the OpenTelemetry POC imports constants from a type that no longer exists. This copies the constants instead as is usually advised to prevent version locks.
This also finishes name conversion from llm -> gen_ai per upstream https://github.com/open-telemetry/semantic-conventions/blob/main/docs/gen-ai/gen-ai-spans.md
Fix #11993