Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] print a message to suggest how to bypass commit hooks #12217

Merged
merged 3 commits into from
Jan 20, 2025
Merged

[misc] print a message to suggest how to bypass commit hooks #12217

merged 3 commits into from
Jan 20, 2025

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Jan 20, 2025 •
edited by github-actions bot
Loading

developers find it annoying if they need to pass linters for temporary commits.

not everyone knows the --no-verify falg.

I added this dummy hook to always print a message to tell users how to bypass hooks.

@youkaichao
add suggestions
fb2b4fc 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
add suggestions
c16bf14 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
add suggestions
4444804 
Signed-off-by: youkaichao <[email protected]>
@youkaichao youkaichao requested a review from hmellor January 20, 2025 09:56
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

youkaichao
youkaichao commented Jan 20, 2025
View reviewed changes
.pre-commit-config.yaml
@@ -81,7 +85,8 @@ repos:
entry: tools/png-lint.sh
language: script
types: [png]
- repo: https://github.com/rhysd/actionlint
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change is to make sure suggestion is the final message.

DarkLight1337
DarkLight1337 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@youkaichao youkaichao merged commit 170eb35 into vllm-project:main Jan 20, 2025
8 of 11 checks passed
@youkaichao youkaichao deleted the no_verify branch January 20, 2025 10:06
@kzawora-intel kzawora-intel mentioned this pull request Jan 21, 2025
Open
mhendrey pushed a commit to mhendrey/vllm that referenced this pull request Jan 23, 2025
@youkaichao @mhendrey
[misc] print a message to suggest how to bypass commit hooks (vllm-pr…
957ca23 
…oject#12217)

Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Matthew Hendrey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@hmellor hmellor hmellor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youkaichao @hmellor @DarkLight1337