Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model][Bugfix]: correct Aria model output #12309

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

xffxff
Copy link
Contributor

@xffxff xffxff commented Jan 22, 2025

fix #12241

The output of python examples/offline_inference/vision_language.py -m aria in my local env is correct

> The image shows a beautiful scene with cherry blossoms in full bloom. The blossoms are in the foreground, framing the view. In the background, there is a tall tower, which appears to be the Tokyo Skytree, a well-known landmark in Japan. The sky is clear and
> The image shows a beautiful scene with cherry blossoms in full bloom. The blossoms are pink and frame the view of a tall structure in the background, which appears to be the Tokyo Skytree, a famous landmark in Japan. The sky is clear and blue, adding to the serene and picturesque
> The image shows a beautiful scene with cherry blossoms in full bloom in the foreground. Behind the blossoms, the Tokyo Skytree, a tall broadcasting and observation tower, is visible against a clear blue sky. The cherry blossoms frame the tower, creating a picturesque and serene
> The image shows a scenic view of the Tokyo Skytree, a famous broadcasting and observation tower in Tokyo, Japan. The tower is partially visible through a frame of cherry blossom trees in full bloom, with pink flowers creating a beautiful contrast against the clear blue sky. The composition highlights the blend of modern

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@xffxff
Copy link
Contributor Author

xffxff commented Jan 22, 2025

@Isotr0py @DarkLight1337 Can you take a look?

@xffxff xffxff changed the title fix: correct Aria model output [Model][Bugfix]: correct Aria model output Jan 22, 2025
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixing!

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 22, 2025
Signed-off-by: xffxff <[email protected]>
@jeejeelee jeejeelee enabled auto-merge (squash) January 22, 2025 10:07
@jeejeelee jeejeelee merged commit 528dbca into vllm-project:main Jan 22, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The output of Aria model is not correct
5 participants