Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardware][Gaudi][Bugfix] Fix error for guided decoding #12317

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhouyu5
Copy link
Contributor

@zhouyu5 zhouyu5 commented Jan 22, 2025

It fixes the error on Gaudi when enabling guided decoding:

RuntimeError: synNodeCreateWithId failed for node: strided_insert with synStatus 1 [Invalid argument]

After fix, all UT have passed for guided decoding and tool calling, including:

vllm-fork/tests/entrypoints/llm/test_guided_generate.py
vllm-fork/tests/tool_use/*.py

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Comment on lines -92 to +96
scores.add_(mask)
if current_platform.is_hpu():
scores = scores.add(mask)
else:
scores.add_(mask)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we simply use scores = scores.add(mask) for all cases? I am not familiar with performance differences between this and scores.add_(mask)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants