Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add docs for prompt replacement #12318

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[Doc] Add docs for prompt replacement #12318

merged 1 commit into from
Jan 22, 2025

Conversation

DarkLight1337
Copy link
Member

Address #12310 (review)

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 22, 2025
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

DarkLight1337
DarkLight1337 commented Jan 22, 2025
View reviewed changes
vllm/model_executor/models/ultravox.py
@@ -218,7 +218,7 @@ def get_replacement_ultravox(item_idx: int):
return [
PromptReplacement(
modality="audio",
target='<|audio|>',
target="<|audio|>",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reverts an unnecessary change in the previous PR.

@Isotr0py Isotr0py enabled auto-merge (squash) January 22, 2025 13:01
@Isotr0py Isotr0py merged commit 6609cdf into vllm-project:main Jan 22, 2025
49 checks passed
@DarkLight1337 DarkLight1337 deleted the repl-details-docs branch January 22, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkLight1337 @Isotr0py