Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Improve the readability of BNB error messages #12320

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Jan 22, 2025

Signed-off-by: Jee Jee Li <[email protected]>
@jeejeelee jeejeelee changed the title [Misc] Improve the readability of BNBerror messages [Misc] Improve the readability of BNB error messages Jan 22, 2025
@jeejeelee jeejeelee requested a review from mgoin January 22, 2025 14:39
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 22, 2025
@mgoin mgoin enabled auto-merge (squash) January 22, 2025 15:01
@mgoin mgoin merged commit 84bee4b into vllm-project:main Jan 22, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants