Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Disallow passing model as both argument and option #7347

Merged
merged 8 commits into from
Aug 12, 2024
Merged

[Frontend] Disallow passing model as both argument and option #7347

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1408bb6
Disallow passing `model` as both argument and option
DarkLight1337 Aug 9, 2024
139a744
Rearrange
DarkLight1337 Aug 9, 2024
a328540
Merge branch 'upstream' into no-duplicate-arg
DarkLight1337 Aug 10, 2024
87c9364
Compare against default value
DarkLight1337 Aug 10, 2024
20cc8ff
format
DarkLight1337 Aug 10, 2024
74d53e4
Merge branch 'upstream' into no-duplicate-arg
DarkLight1337 Aug 12, 2024
bb2a0a9
Grammar
DarkLight1337 Aug 12, 2024
0d121e4
Reference the default value directly
DarkLight1337 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vllm/scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ def signal_handler(sig, frame):


def serve(args: argparse.Namespace) -> None:
if args.model is not None:
DarkLight1337 marked this conversation as resolved.
Show resolved Hide resolved
raise ValueError(
"In `vllm serve`, you should provide the model as a "
DarkLight1337 marked this conversation as resolved.
Show resolved Hide resolved
"positional argument instead of via the `--model` option.")

# EngineArgs expects the model name to be passed as --model.
args.model = args.model_tag

Expand Down
Loading