Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fde.md: Clarifying base-system installation. #566

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kz6wk9
Copy link

@kz6wk9 kz6wk9 commented Apr 20, 2021

Making clearer to the reader that the actual installation command should
point to the correct repo for the chosen libc implementation, this helps
eliminate the possibility of a wrong system installation.

@kz6wk9 kz6wk9 changed the title Clarifying installation link. src/installation/guides/fde.md: Clarifying installation link. Apr 20, 2021
@kz6wk9 kz6wk9 changed the title src/installation/guides/fde.md: Clarifying installation link. fde.md: Clarifying installation link. Apr 20, 2021
@ericonr
Copy link
Member

ericonr commented Apr 20, 2021

And changing the PR name doesn't fix the commit name, unfortunately ;)

@kz6wk9 kz6wk9 changed the title fde.md: Clarifying installation link. fde.md: Clarifying base-system installation. Apr 20, 2021
@kz6wk9
Copy link
Author

kz6wk9 commented Apr 20, 2021

And changing the PR name doesn't fix the commit name, unfortunately ;)

Fixed!!!

And after reading chroot.md I found out some spots that could use some linking indeed, so I pointed out the packages the user will need alongside with base-system and linked the rest of the procedure from chroot.md.
I also found to be more readable to separate the grub installation from the base-system, this way it should be more consistent with the chroot.md procedure where the grub installation is only mentioned after inside the chroot.
Another point is that we would be able to avoid mentioning modifications to /etc/default/grub in separate sections of the fde.md guide as it is now, but instead do the package installation, configuration, and installation to disk all in one single section.

@ericonr
Copy link
Member

ericonr commented Apr 20, 2021

Please make these changes in separate commits (can be in this same PR, though), since they are mostly unrelated.

@kz6wk9
Copy link
Author

kz6wk9 commented Apr 21, 2021

All done !
Please, let me know if there's anything else that could be improved!

Comment on lines 125 to 127
Follow the instructions on [Base Installation](chroot.md#base-installation) to
install the `base-system` and, additionally, the other important packages we
need in this specific case, those are: `lvm2` and `cryptsetup`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Follow the instructions on [Base Installation](chroot.md#base-installation) to
install the `base-system` and, additionally, the other important packages we
need in this specific case, those are: `lvm2` and `cryptsetup`.
Follow the instructions for a [base installation](chroot.md#base-installation) to
install the `base-system` package together with the packages needed for this guide: `lvm2` and `cryptsetup`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the mention of GRUB UEFI.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because, as I said before, to be more consistent with chroot.md, grub could be mentioned only later on as one of the last steps of the installation, and this would help by removing the mentions to modifications on ´/etc/default/grub´ on separate steps of the installation as well, by putting then all together at the end.
This could probably help further improvements of repetition removal on the fde.md guide in the future too, since the more consistent the flows of installation are with each other the easier it is to spot duplicated parts.

src/installation/guides/fde.md Outdated Show resolved Hide resolved
src/installation/guides/fde.md Outdated Show resolved Hide resolved
kz6wk9 added 2 commits May 12, 2021 03:38
Making clearer to the reader that the actual installation command should
use the appropriate URL.
Separating GRUB installation and configuration from the base-system
section to make the installation procedures (chroot and fde) more
consistent, making easier to mention one single source to avoid
repetition.
Copy link

@dkwo dkwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest to use cryptsetup -y -v luksFormat /dev/sda1 (with explicit verbose and verify options, as well as removing the paragraph on luks1 and grub, provided it all works now with 2.06) and cryptsetup open --type luks /dev/sda1 voidvm (modern syntax) instead?

@ghost ghost mentioned this pull request Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants