-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fde.md: Clarifying base-system installation. #566
base: master
Are you sure you want to change the base?
Conversation
And changing the PR name doesn't fix the commit name, unfortunately ;) |
Fixed!!! And after reading |
Please make these changes in separate commits (can be in this same PR, though), since they are mostly unrelated. |
All done ! |
src/installation/guides/fde.md
Outdated
Follow the instructions on [Base Installation](chroot.md#base-installation) to | ||
install the `base-system` and, additionally, the other important packages we | ||
need in this specific case, those are: `lvm2` and `cryptsetup`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the instructions on [Base Installation](chroot.md#base-installation) to | |
install the `base-system` and, additionally, the other important packages we | |
need in this specific case, those are: `lvm2` and `cryptsetup`. | |
Follow the instructions for a [base installation](chroot.md#base-installation) to | |
install the `base-system` package together with the packages needed for this guide: `lvm2` and `cryptsetup`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the mention of GRUB UEFI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because, as I said before, to be more consistent with chroot.md
, grub could be mentioned only later on as one of the last steps of the installation, and this would help by removing the mentions to modifications on ´/etc/default/grub´ on separate steps of the installation as well, by putting then all together at the end.
This could probably help further improvements of repetition removal on the fde.md
guide in the future too, since the more consistent the flows of installation are with each other the easier it is to spot duplicated parts.
Making clearer to the reader that the actual installation command should use the appropriate URL.
Separating GRUB installation and configuration from the base-system section to make the installation procedures (chroot and fde) more consistent, making easier to mention one single source to avoid repetition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest to use cryptsetup -y -v luksFormat /dev/sda1
(with explicit verbose and verify options, as well as removing the paragraph on luks1 and grub, provided it all works now with 2.06) and cryptsetup open --type luks /dev/sda1 voidvm
(modern syntax) instead?
Making clearer to the reader that the actual installation command should
point to the correct repo for the chosen libc implementation, this helps
eliminate the possibility of a wrong system installation.