This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
A support for comments on data requests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lsa-nathan/ckanext-ytp-comments into feature/data-request-comments
Conflicts resolved:
ckanext/ytp/comments/templates/package/comment_list.html
salsa-nathan
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds functionality to support comments on data requests (
ckanext-datarequests) using the YTP comments extension.Approach
Introduces the
content_typeconcept to support content types such as data requests, in addition to existing dataset commenting.Provides helper functions to address the differences between routes and permissions of datasets and data requests.
Adds template overrides for the data requests comment and show templates.
CKAN routes were added to handle generic display, submission, editing and deleting of comments, with
datasetbeing the default content type.