Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

fix #13

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix #13

Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix
vultj committed Jun 21, 2024
commit a750184a757bfcf5c870a1ca3d3e03c4acf0759e
File renamed without changes.
File renamed without changes.
File renamed without changes.
16 changes: 8 additions & 8 deletions helm/slinkee/values.yaml → helm/slik/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
slik:
repository: ewr.vultrcr.com/slurm/slik
tag: v0.0.2
tag: v0.0.3
resources:
requests:
memory: "1Gi"
@@ -16,19 +16,19 @@ slik:

slurm:
slurmabler:
image: "ewr.vultrcr.com/slurm/slurmabler:v0.0.2"
image: "ewr.vultrcr.com/slurm/slurmabler:v0.0.3"
service_account: "slik"
munged:
image: "ewr.vultrcr.com/slurm/munged:v0.0.2"
image: "ewr.vultrcr.com/slurm/munged:v0.0.3"
slurmctld:
image: "ewr.vultrcr.com/slurm/slurmctld:v0.0.2"
image: "ewr.vultrcr.com/slurm/slurmctld:v0.0.3"
slurmd:
image: "ewr.vultrcr.com/slurm/slurmd:v0.0.2"
image: "ewr.vultrcr.com/slurm/slurmd:v0.0.3"
slurm_toolbox:
image: "ewr.vultrcr.com/slurm/toolbox:v0.0.2"
image: "ewr.vultrcr.com/slurm/toolbox:v0.0.3"
mariadb:
image: "mariadb:11.4.2-noble"
slurmdbd:
image: "ewr.vultrcr.com/slurm/slurmdbd:v0.0.2"
image: "ewr.vultrcr.com/slurm/slurmdbd:v0.0.3"
slurmrestd:
image: "ewr.vultrcr.com/slurm/slurmrestd:v0.0.2"
image: "ewr.vultrcr.com/slurm/slurmrestd:v0.0.3"

Unchanged files with check annotations Beta

package config
// checkConfig checks the config for validity
func checkConfig() error {

Check failure on line 5 in cmd/slik/config/checks.go

GitHub Actions / Golangci-Lint

cyclomatic complexity 11 of func `checkConfig` is high (> 10) (gocyclo)

Check failure on line 5 in cmd/slik/config/checks.go

GitHub Actions / Golangci-Lint

cyclomatic complexity 11 of func `checkConfig` is high (> 10) (gocyclo)
switch cfg.Logging.Encoding {
case "json", "console":
// no-op
package config
// checkConfig checks the config for validity
func checkConfig() error {

Check failure on line 5 in cmd/slurmabler/config/checks.go

GitHub Actions / Golangci-Lint

func `checkConfig` is unused (unused)

Check failure on line 5 in cmd/slurmabler/config/checks.go

GitHub Actions / Golangci-Lint

func `checkConfig` is unused (unused)
return nil
}
}
// initConf initializes the configuration
func initConf(name, cfgFile string) error {

Check failure on line 48 in cmd/slurmabler/config/config.go

GitHub Actions / Golangci-Lint

func `initConf` is unused (unused)

Check failure on line 48 in cmd/slurmabler/config/config.go

GitHub Actions / Golangci-Lint

func `initConf` is unused (unused)
data, err := os.ReadFile(cfgFile)
if err != nil {
return fmt.Errorf("os.ReadFile failed: %w", err)
}
// initLogging initializes logging
func initLogging(logfile string, stdout bool) error { //nolint

Check failure on line 65 in cmd/slurmabler/config/config.go

GitHub Actions / Golangci-Lint

directive `//nolint` is unused (nolintlint)

Check failure on line 65 in cmd/slurmabler/config/config.go

GitHub Actions / Golangci-Lint

directive `//nolint` is unused (nolintlint)
var stdoutPaths []string
var stderrPaths []string
"context", name,
).Info("reconciler: starting")
recon.Run()

Check failure on line 105 in cmd/slik/main.go

GitHub Actions / Golangci-Lint

Function `Run->loop->SlurmDelete->GetAllNodes` should pass the context parameter (contextcheck)

Check failure on line 105 in cmd/slik/main.go

GitHub Actions / Golangci-Lint

Function `Run->loop->SlurmDelete->GetAllNodes` should pass the context parameter (contextcheck)
}
return nil
}
// initLogging initializes logging
func initLogging(logfile string, stdout bool) error { //nolint

Check failure on line 153 in cmd/slik/config/config.go

GitHub Actions / Golangci-Lint

directive `//nolint` is unused (nolintlint)

Check failure on line 153 in cmd/slik/config/config.go

GitHub Actions / Golangci-Lint

directive `//nolint` is unused (nolintlint)
var stdoutPaths []string
var stderrPaths []string
date = "unknown"
)
func main() { //nolint

Check failure on line 27 in cmd/slurmabler/main.go

GitHub Actions / Golangci-Lint

directive `//nolint` is unused (nolintlint)

Check failure on line 27 in cmd/slurmabler/main.go

GitHub Actions / Golangci-Lint

directive `//nolint` is unused (nolintlint)
_, err := config.NewConfig(name)
if err != nil {
logger, _ := zap.NewDevelopment()