Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some parser bugs #62

Merged
merged 16 commits into from
Dec 13, 2024
Merged

Fix some parser bugs #62

merged 16 commits into from
Dec 13, 2024

Conversation

NTTVy03
Copy link
Collaborator

@NTTVy03 NTTVy03 commented Dec 8, 2024

  1. Remove pub in the syntax test programs module
  2. Format: add line breaks for better readability:
  3. Remove some unused comments in syntax tests
  4. Make Pragma optional
  5. Remove ROOT in circom_program parser
  6. Rename close() params (marker_close --> marker_open)
  7. Use advance() in eat()
  8. Fix typo scrope --> scope
  9. Parse params using list_identity::parse() in template and function parser

@NTTVy03 NTTVy03 changed the title Remove pub in syntax test programs module Fix some parser bugs Dec 8, 2024
Copy link
Owner

@vuvoth vuvoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approve! Fix Rust format before we merge!

@NTTVy03 NTTVy03 requested a review from vuvoth December 13, 2024 07:35
@vuvoth vuvoth merged commit 18ec997 into vuvoth:master Dec 13, 2024
1 check passed
NTTVy03 added a commit to NTTVy03/ccls that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants