-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate darwin install #43
Conversation
This change doesn't "install" keyboard support, that requires SIP to be disabled to add |
README.md
Outdated
@@ -32,20 +32,24 @@ which is required by the automation voice. | |||
|
|||
npm install -g @bocoup/windows-sapi-tts-engine-for-automation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unable to run this with the published package.
I had to do
chmod +x ./bin/at-driver
and ./bin/at-driver
in place of all instances of at-driver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this problem exists on the main
branch, I've submitted a fix via a separate pull request.
README.md
Outdated
If prompted for system administration permission, grant permission. | ||
|
||
2. Start the server by executing the following command in a terminal: | ||
3. Start the server by executing the following command in a terminal: | ||
|
||
at-driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This required sudo
the first time in order to make the required directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change doesn't "install" keyboard support, that requires SIP to be disabled to add
osascript
to the System Settings > Security & Privacy > Accessibility list. The keyboard support step would best be done manually, which doesn't require SIP to be disabled.
This sounds like a good direction to me. It seems important to reflect this expectation in the installation script itself, even with the understanding that manual intervention would usually be necessary:
- in the "interactive" setting (i.e. a developer typing
at-driver install
into their terminal), the script could prompt the user to enable keyboard support and pause until they do so - in the "unattended" setting (i.e. running
at-driver install --unattended
in a continuous integration environment), the script could attempt to perform the installation automatically (we know this will fail when SIP is enabled, but it would work in environments where SIP has been disabled, and I believe that includes GitHub Actions
These accommodations could of course be skipped entirely if the system is already configured to allow keyboard automation.
In pseudocode:
while hasKeyboardSupport() == false
if unattendedInstall
enableKeyboardSupport()
else
print('Please enable keyboard support and then press any key')
waitForKeyPress()
f46d337
to
e05b38e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Other than the concern with running the uninstall
command, but I don't think that has to be a blocker right now, considering this will run in CI (being tracked in #50)
|
||
/** | ||
* @param {object} options | ||
* @param {boolean} options.unattended - Whether installation should fail if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad you think so; I had trouble explaining it in a way that even kind of makes sense
Thanks, @howard-e! Thanks, @stalgiag! Thanks, @mzgoddard! |
This pull request depends on #42.
Add macos/darwin installation. This installs the voice for VoiceOver.