Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting #56

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

jugglinmike
Copy link
Contributor

I wrote this to assist debugging in gh-55.

@jugglinmike jugglinmike requested a review from stalgiag June 5, 2024 23:18
@jugglinmike jugglinmike force-pushed the improve-test-error-reporting branch from 4ffe596 to 4bd0a1d Compare June 5, 2024 23:23
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the errors are much more informative now. Nice to be able to see the server errors directly in the JS test output. Code looks good and straightforward. May one day want to generalize but this is fine for now

@jugglinmike
Copy link
Contributor Author

Thanks!

@jugglinmike jugglinmike merged commit 64ce4c5 into w3c:main Jun 11, 2024
3 checks passed
@jugglinmike jugglinmike deleted the improve-test-error-reporting branch June 11, 2024 01:43
jugglinmike added a commit to bocoup/at-driver-servers that referenced this pull request Jun 19, 2024
This commit has been cherry-picked from the "aria-at-automation-driver"
project, where it was previously reviewed and approved [1].

[1] w3c/aria-at-automation-driver#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants