Change *ResponseJSON.id to DOMString
#2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlun
approved these changes
Aug 14, 2024
agl
approved these changes
Aug 14, 2024
pascoej
approved these changes
Aug 14, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 14, 2024
SHA: 9135ead Reason: push, by MasterKale Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 14, 2024
To follow w3c/webauthn#2120. It was a DOMString by another name before, so this change is non-breaking. Change-Id: I9c341594a493bbc97d94e7dea0bb1d567e6d221d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5789432 Reviewed-by: Nina Satragno <[email protected]> Commit-Queue: Martin Kreichgauer <[email protected]> Commit-Queue: Nina Satragno <[email protected]> Auto-Submit: Martin Kreichgauer <[email protected]> Cr-Commit-Position: refs/heads/main@{#1341983}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines typing in
RegistrationResponseJSONandAuthenticationResponseJSONto remove confusion around the shape of the value of JSON-serializedCredential.id.Fixes #2119.
Preview | Diff