argocd: new params for UpdateSpec and CreateUpdate actions. fix timeout issues #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hemant0308
commented
Jun 2, 2024
hemant0308
commented
- Add options waitForSync,syncTimeout,watchHealth parameters for UpdateSpec and CreateUpdate operations
- Fixed timeout issues for waitForSync method by moving BuffereReader instance creation statement from try-with-resource block.
…teSpec and CreateUpdate operations * Fixed timeout issues for waitForSync method by moving BuffereReader instance creation statement from try-with-resource block.
benbroadaway
requested changes
Jun 3, 2024
tasks/argocd/src/main/java/com/walmartlabs/concord/plugins/argocd/CallRetry.java
Outdated
Show resolved
Hide resolved
tasks/argocd/src/main/java/com/walmartlabs/concord/plugins/argocd/CallRetry.java
Outdated
Show resolved
Hide resolved
tasks/argocd/src/main/java/com/walmartlabs/concord/plugins/argocd/CallRetry.java
Outdated
Show resolved
Hide resolved
tasks/argocd/src/main/java/com/walmartlabs/concord/plugins/argocd/TaskParamsImpl.java
Outdated
Show resolved
Hide resolved
tasks/argocd/src/main/java/com/walmartlabs/concord/plugins/argocd/ArgoCdTask.java
Outdated
Show resolved
Hide resolved
tasks/argocd/src/main/java/com/walmartlabs/concord/plugins/argocd/ArgoCdTask.java
Outdated
Show resolved
Hide resolved
benbroadaway
approved these changes
Jun 5, 2024
benbroadaway
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.