code coverage runtime plugin #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brig
commented
Dec 1, 2024
brig
commented
ibodrov
reviewed
Dec 3, 2024
...ecoverage/src/main/java/com/walmartlabs/concord/plugins/codecoverage/CodecoverageModule.java
Outdated
Show resolved
Hide resolved
...me/codecoverage/src/main/java/com/walmartlabs/concord/plugins/codecoverage/CodeCoverage.java
Outdated
Show resolved
Hide resolved
...me/codecoverage/src/main/java/com/walmartlabs/concord/plugins/codecoverage/CodeCoverage.java
Outdated
Show resolved
Hide resolved
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonSerialize(as = ImmutableStepInfo.class) | ||
| @JsonDeserialize(as = ImmutableStepInfo.class) | ||
| public interface StepInfo { |
There was a problem hiding this comment.
Maybe StepInfo can be a record?
The builder is used only in one place and can be replaced with a static builder method or a constructor.
Minus one dependency and a build step. :-)
...me/codecoverage/src/main/java/com/walmartlabs/concord/plugins/codecoverage/CodeCoverage.java
Outdated
Show resolved
Hide resolved
ibodrov
previously approved these changes
Dec 4, 2024
...e/codecoverage/src/main/java/com/walmartlabs/concord/plugins/codecoverage/StepsRecorder.java
Outdated
Show resolved
Hide resolved
...me/codecoverage/src/main/java/com/walmartlabs/concord/plugins/codecoverage/CodeCoverage.java
Outdated
Show resolved
Hide resolved
…gins/codecoverage/CodecoverageModule.java Co-authored-by: Ivan Bodrov <[email protected]>
…gins/codecoverage/CodeCoverage.java Co-authored-by: Ivan Bodrov <[email protected]>
…gins/codecoverage/StepsRecorder.java Co-authored-by: Ivan Bodrov <[email protected]>
…gins/codecoverage/CodeCoverage.java Co-authored-by: Ivan Bodrov <[email protected]>
ibodrov
force-pushed
the
brig/code-coverage
branch
from
656f538 to
f4e2b76
Compare
ibodrov
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.