Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: require run in InterfaceBase.publish_partial_history #9264

Open
wants to merge 1 commit into
base: spr/timoffex/main.refactor-require-run-in-interfacebasepublish_partial_history
Choose a base branch
from

Conversation

timoffex
Copy link
Contributor

@timoffex timoffex commented Jan 15, 2025

Similarly to #9263, makes the run parameter in publish_partial_history required, reducing dependence on _hack_set_run(). The only callsite is Run._partial_history_callback which did not formerly provide a run.

This is riskier than the other PR because it assumes that in Run._partial_history_callback, self is equal to self._backend.interface._run, so that passing run=self is equivalent to not passing run like before. I would be somewhat surprised if a Run instance ever interacted with an InterfaceBase with a different _run.

Created using spr 1.3.5
@timoffex timoffex changed the title refactor: require Run in InterfaceBase.publish_partial_history refactor: require run in InterfaceBase.publish_partial_history Jan 15, 2025
@timoffex timoffex requested a review from a team January 15, 2025 00:20
@timoffex timoffex marked this pull request as ready for review January 15, 2025 00:20
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.69%. Comparing base (1eb7678) to head (2e55c1c).

Additional details and impacted files

Impacted file tree graph

@@                                                Coverage Diff                                                 @@
##           spr/timoffex/main.refactor-require-run-in-interfacebasepublish_partial_history    #9264      +/-   ##
==================================================================================================================
- Coverage                                                                           72.69%   72.69%   -0.01%     
==================================================================================================================
  Files                                                                                 545      545              
  Lines                                                                               58123    58122       -1     
==================================================================================================================
- Hits                                                                                42250    42249       -1     
  Misses                                                                              15154    15154              
  Partials                                                                              719      719              
Flag Coverage Δ
func 37.01% <ø> (+0.01%) ⬆️
system 57.75% <ø> (-0.05%) ⬇️
unit 51.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
wandb/sdk/interface/interface.py 88.13% <ø> (-0.03%) ⬇️
wandb/sdk/wandb_run.py 89.38% <ø> (ø)

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants