refactor: require run in InterfaceBase.publish_partial_history #9264
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #9263, makes the
run
parameter inpublish_partial_history
required, reducing dependence on_hack_set_run()
. The only callsite isRun._partial_history_callback
which did not formerly provide a run.This is riskier than the other PR because it assumes that in
Run._partial_history_callback
,self
is equal toself._backend.interface._run
, so that passingrun=self
is equivalent to not passingrun
like before. I would be somewhat surprised if aRun
instance ever interacted with anInterfaceBase
with a different_run
.