feat(model): max_concurrent instead of replicas #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
feat/max-concurrent-replicas
branch
from
6ec32a2 to
d62bac3
Compare
brooksmtownsend
force-pushed
the
feat/max-concurrent-replicas
branch
2 times, most recently
from
ecdb1db to
167b090
Compare
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
connorsmith256
as code owners
connorsmith256
previously approved these changes
Dec 13, 2023
instead of replicas Signed-off-by: Brooks Townsend <[email protected]> update model and code
Signed-off-by: Brooks Townsend <[email protected]> update yamls and readmes
brooksmtownsend
force-pushed
the
feat/max-concurrent-replicas
branch
from
167b090 to
664185a
Compare
connorsmith256
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR updates the manifest definition to refer to replicas of actors and providers as
instances, rather than simplyreplicas. After the change to the host to effectively autoscale to a maximum concurrent load, we aren't really spreading replicas around like we used to.I acknowledge this is a little awkward when it comes to having an underscore in a yaml property, and the fact that this doesn't really make as much sense for capability providers. For that reason this is a change that's mostly internal, and you can still use
replicasas the property for now. In the future, I would love to rethink this trait property and how it pertains to our scaling model. With capability providers being WASI-based, it may make sense to use this concurrency property for providers too.Related Issues
Changes in the host implemented in wasmCloud/wasmCloud#1107. After that merges and the new control interface cuts, we'll need to update our test code in wadm to change the
u16values tou32s.Release Information
v0.9.0 or v0.10.0
Consumer Impact
This, from a model standpoint, is a backwards compatible change and we'll support
replicasas an option for the forseeable future. This just lets us use consistent wording across projects.Testing
Unit Test(s)
Modified all YAMLs other than one (to ensure backwards compatibility) to denote
replicasasinstances.Acceptance or Integration
Manual Verification