Merge pull request #239 from modern-js-dev/fix/remote-externals

fix(remoteModule): merge global externals bug
web-infra-dev · Oct 19, 2021 · 79cb86d · 79cb86d
2 parents e644e18 + cdecb3e
commit 79cb86d
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/packages/remote-module/src/common.ts b/packages/remote-module/src/common.ts
@@ -79,17 +79,22 @@ export const getModuleCode = (url: string) => {
 
 export const purifyOptions = (urlOrAlias: string, options?: ModuleInfo) => {
   let config;
+  const globalExternals = moduleConfig.externals;
+  delete moduleConfig.externals;
 
   if (isPlainObject(options)) {
-    const cloned = { ...options };
-    const externals = { ...moduleConfig.externals, ...options.externals };
-    delete cloned.externals;
-    config = deepMerge(moduleConfig, { ...cloned, url: urlOrAlias });
-    config.externals = externals;
+    const curExternals = options.externals;
+    delete options.externals;
+    config = deepMerge(moduleConfig, { ...options, url: urlOrAlias });
+    options.externals = curExternals;
+    config.externals = { ...globalExternals, ...curExternals };
   } else {
     config = deepMerge(moduleConfig, { url: urlOrAlias });
+    config.externals = globalExternals;
   }
 
+  moduleConfig.externals = globalExternals;
+
   return config as ModuleInfo & {
     url: string;
   };