feat: support remove plugin

web-infra-dev · Jul 12, 2024 · 99861bc · 99861bc
1 parent 6d8ac4d
commit 99861bc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/core/src/garfish.ts b/packages/core/src/garfish.ts
@@ -95,6 +95,10 @@ export class Garfish extends EventEmitter2 {
     return this;
   }
 
+  removePlugin(pluginName: string) {
+    this.hooks.removePlugin(pluginName);
+  }
+
   run(options: interfaces.Options = {}) {
     if (this.running) {
       if (__DEV__) {

diff --git a/packages/hooks/src/pluginSystem.ts b/packages/hooks/src/pluginSystem.ts
@@ -44,7 +44,7 @@ export class PluginSystem<T extends Record<string, any>> {
     assert(plugin, `plugin "${pluginName}" is not registered.`);
 
     for (const key in plugin) {
-      if (key === 'name') continue;
+      if (key !== 'name') continue;
       this.lifecycle[key].remove(plugin[key as string]);
     }
   }