Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OpenLayers to version 8.1.0 #353

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

chrismayer
Copy link
Collaborator

@chrismayer chrismayer commented Oct 18, 2023

This upgrades OpenLayers to version 8.1.0.

I went through the upgrade notes and checked that there are no breaking changes, which will affect the code base of Wegue. Dev-setup and production build look fine so far.

Based on #352.

Fixes #329

Copy link
Collaborator

@JakobMiksch JakobMiksch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the basic functionality of the map manually in the browser and everything seems to work as expected.

Copy link
Collaborator

@sronveaux sronveaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrismayer, having this included in the upcoming next version of Wegue is for sure a top-upgrade thing! Let's hope V8 of OpenLayers will stay for longer than V7 had...

Tested it in a bigger application and everything seems to work as expected. It looks perfectly fine for me.

@chrismayer
Copy link
Collaborator Author

Thanks for your reviews @JakobMiksch and @sronveaux. Going to merge now...

@chrismayer chrismayer merged commit b0d5575 into wegue-oss:master Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest OpenLayers
3 participants