-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Windows runner for unit tests CI job #126
Conversation
Hm, nevermind. I think I don't have permission to change and run the workflow like this in a pull request. I'll create a new repository on my own account and test there before re-opening this. |
8545b49
to
5befe71
Compare
This is running correctly now, but an issue in vim-testify prevents me overriding |
Just to make sure I understand the scope - this is intended to run the unit tests on Windows, but it does not fix the unit tests, correct? |
.github/workflows/ci.yml
Outdated
- name: Create a fake code-minimap executable | ||
# Necessary for minimap.vim to start up | ||
run: | | ||
mkdir -p "$HOME/bin" | ||
ln -s /bin/echo "$HOME/bin/code-minimap" | ||
echo "$HOME/bin" >> $GITHUB_PATH | ||
if: ${{ !contains(matrix.os, 'windows') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these if
gates have to be at the bottom? It would be nice if it was the first part of the yaml section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, I've moved them to the first key in the block. Let's see if GitHub accepts it.
That's right. I'd hoped to look at them after finishing this but went down the rabbit hole of fixing vim-testify to get test results from it in CI. Unless you get to them before I wrap this branch up I'll take a look once I've got this producing good output. |
NOTE: still WIP.
Check list
Description
This is an attempt to get the unit tests running under Windows in CI to hopefully help with testing issues like #109. There's a few kinks to iron out, so I've opened this as a draft until I get it passing. Ideally it'll remain mostly the same, with just the code-minimap stub and paths to neovim plugins changing.
Type of change
Test environment